Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native E-commerce Complement Icons #2432

Conversation

renanmalato
Copy link

Custom Icons for React Native E-commerce Projects

• Empties
• Favorites
• Profile
• Orders
• Skeletons (for skeleton loads)
• Empties (for empty states)

commit

This PR adds custom icons for the folder and in the settings.json is the trigger to add in the /dist/material-icons.json file with the necessary triggers for the new icons.

Changes:

  • Added folder-empties.svg and folder-empties-open.svg to the icons directory.
  • Added folder-favorites.svg and folder-favorites-open.svg to the icons directory.
  • Added folder-orders.svg and folder-orders-open.svg to the icons directory.
  • Added folder-profile.svg and folder-profile-open.svg to the icons directory.
  • Added folder-skeletons.svg and folder-skeletons-open.svg to the icons directory.
  • Included settings.json with configuration changes to trigger the new icon names.

Please review the changes and consider merging them into the main repository.

Thank you!

Copy link
Contributor

github-actions bot commented Jul 18, 2024

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

🏞️ Generated preview
Generated preview

Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@PKief PKief force-pushed the main branch 2 times, most recently from ed9ed26 to 55e5e9c Compare September 20, 2024 19:17
@PKief PKief force-pushed the main branch 2 times, most recently from 7918c28 to 7cb05b2 Compare November 13, 2024 14:45
@PKief PKief added the 🚨 merge conflicts PR has merge conflicts label Jan 4, 2025
@PKief
Copy link
Member

PKief commented Jan 4, 2025

To improve the quality and to reduce the maintenance effort regular refactoring of the project is inevitable. As much as we appreciate your work and contribution in this pull request, we realised that it was created a while ago and some merge conflicts occurred.

We have decided to close all PRs that no longer correspond to the current code base. This gives us the opportunity to provide a better overview of the remaining open PRs.

We would like to offer you to update your changes to the main branch and reopen the PR if the contribution is still relevant for you. Please contact us, we will be happy to help you resolve any conflicts.

Thank you for your attention and good collaboration.

@PKief PKief closed this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 merge conflicts PR has merge conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants